CodePlex Home
Register | Sign In | CodePlex Home
1 vote
closed
DK: Sigil of Haunted Dreams has wrong proc chance

Description

 
Okay, this one is my fault. I completely missed this when I was doing my work.

Sigil of Haunted Dreams is currently modeled as having a 100% chance on use of BS or HS to add 173 crit rating for 10 seconds.

According to wowhead, the proc only has a 15% chance to occur. No cooldown is mentioned there but it may have the standard 45s internal cooldown.

Shazear, I'd write a patch for this but I don't know how this would affect the sigil code you wrote since it's general purpose and I'd probably just end up hard-coding in a definition like I did originally.

References:
http://www.wowhead.com/?spell=60826

File Attachments


Closed Aug 8 2009 at 2:01 AM  by Shazear

Closing old Fixed defects.... Esp. since there's been quite a few builds since these were marked fixed. Any new instances of those issues should be created in new defects.

Comments

most recent at top (show oldest at top)
Soraia wrote Jun 19 2009 at 3:15 PM
Patch applied.

Soraia wrote May 29 2009 at 9:57 PM
Attached dkhaunteddreams.patch fixes this issue by:
1. Hard-coding a condition for the Sigil of Haunted Dreams special effect.
2. Changing the chance in StatsSpecialEffects for Trigger.BloodStrikeOrHeartStrikeHit to 1f.

Soraia wrote May 22 2009 at 8:44 PM
That would explain why manually changing the proc chance in my local copy didn't result in a large change for the sigil's rating.

Bloodysorc wrote May 22 2009 at 8:15 PM
In StatsSpecialEffects --> getSpecialEffects :
case Trigger.BloodStrikeOrHeartStrikeHit:
trigger = (rotation.BloodStrike + rotation.HeartStrike) / rotation.curRotationDuration;
chance = 0.15f;
break;
I hard-coded the 15% chance in the DPSDK model, even though I shouldn't've

Updating...
© 2006-2010 Microsoft | About CodePlex | Privacy Statement | Terms of Use | Code of Conduct | Advertise With Us | Version 2010.1.12.16187