DPSDK: Factor out normalized damage?

Topics: Rawr.DPSDK
May 26, 2009 at 6:26 PM

Most (if not all, I only looked at a handful) of the DPSDK strike damages use code like this to determine the normalized weapon damage: (combatTable.MH.baseDamage + ((stats.AttackPower / 14f) * (DW ? 2.4f : 3.3f)))

Since this shows up in every strike, why not factor this out, either into combatTable.MH or a variable earlier in the GetCharacterCalculations method?  This would decrease the number of calculations needed (although it's not like there are very many to begin with) and would make the formulas for calculating strike damages a little clearer.

(Also, the formula is wrong since it'll treat a 1h sword as if it were a 2h one as long as there is no off-hand weapon equipped.  This is really minor though since almost all 1h weapons  should be rated lower than 2h weapons of roughly equal ilevel anyway.)

May 27, 2009 at 3:15 AM

Yeah, it's a less-than-ideal method that I've been meaning to factor out; it's on the list.