[RestoSham] Issues

Topics: Rawr.RestoSham
Developer
Jul 1, 2009 at 4:43 AM

I decided to not make a new issue of this, but decided to put it here because I have a habit of overlooking things and making simple mistakes.

Restoration Shaman Model, Rawr v2.2.8

Minor:

  • Have to either update Item Cache or manually insert in values for Totem bonuses (sometimes get an error when doing this though: get the standard vista "This program has encountered a problem".  If I get this again, I'll post an issue with the details.)
  • Can only see the very top of the Overhealing slider in the options panel
  • Trinkets special effects aren't completely modelled (easy enough to make do by putting in average values.. so meh)
  • Inserting values into the "activity box, the Earth Shield recast box, the cleanse box, changing anything in the mana potion/+mana tide/hymn of hope/inervate/totems/heroism box" in the options panel changes nothing

Non-minor (possibly major):

  • Adding/removing talents in Improved Water Shield changes nothing in the stats panel.
  • Items that "Restore Mana on Cast" don't seem to work at all (this is mainly trinkets but also effects the Meta gem 'Insightful Earthsiege Diamond')
  • Adding/removing talents in Ancestral Awakening changes nothing in the stats panel.
  • Because of the two above problems with talents, items with crit seem to be undervalued.
  • Glyph of Earth Shield and Glyph of Riptide change no values in the stats panel when selected/deselected

If I run into any more, ill update this as needed.

Jul 1, 2009 at 5:35 AM

Not sure about some of the issues there, but for some of the mana regen one eg. Water Shield and the trinkets/meta, if the fight conditions you have selected show you not running out of mana by the end of the fight, then watershield and mana return changes aren't going to affect anything.   If you increase the length of the fight or reduce the amount of replenishment you get to the point where you will be OOM without these talents (or indeed with them) then you should see some effect from these on the relative stats etc.

 

 

 

Developer
Jul 1, 2009 at 6:19 AM

I did think about this, and all of my mentioned problems are still there when the length of the fight is at 5 mins, 10 mins, or 15 mins.  They are also there if i say that I have 0% replenishment uptime.  If I say that I don't drop a mana tide totem, the problems are still there.  Any combination of these and the problems are still there.

To test even further, I started a new "character", chose no gear, and went through and did the same tests as before.  The problems still appear to be there.  Either I'm doing something hopelessly wrong, or the problems are there.

If needed, my character is Timetodance of Nagrand (US).  I should be in my resto gear.

Developer
Jul 6, 2009 at 5:20 PM

As of the most recent build, you should see a lot of changes in this part.  Mainly the way things were calculated has always been a little off, they should be much more exact.  If possible, let me know if you still have this issues in the most recent source build if you can, or the next posted build if you can't compile the source in some way.  I rarely get much input in the way of features or issues other then the rare issue ticket, so I am always happy to get input on the module.

 

As of most recent posted build:

Mana better defined, before there was almost no way to make haste show up as a benefit, sustained healing is now refined enough to know when to start adding haste.

Earth-shield glyph should now work correctly (Riptide, as of yet, has not.  still working on figuring a good way to add it, since most sequences it is either a major component and is always considered "refreshed", or eaten by CH.)

Ancestral Awakeneing has essentially been converted into a sort of bonus crit healing, but is done after all crit calcs now, should notice a much better impact of it.

Still working on the item procs, like IED, that "should" be coming soon, but I can't put a set time on it yet.

 

Again, anything you notice or think might be helpful, just let me know, there are so few of us around some days (Restoration Shaman's that is)

Developer
Jul 7, 2009 at 4:51 AM

OK, playing around with the latest source build (Change Set 35151) and will let you know as I find things.  One thing that jumped out at me is that when selecting the ranged slot to change totems, I run into the following problem:

The list of available totems appear, but when I mouse over a totem to either select it or see what bonus it provides, rawr seems to lock up for a period of time until the "tooltip" box appears.  The period of time that it locks up for varies but has been upwards of 3 minutes.

 

Also, Glyph of Earth Shield does indeed seem to be working now, haven't checked any numbers but it is changing values.  Still nothing changing with Ancestral Awakening talents selected/deselected, but I could be missing things as I'm doing this on my break at work.

 

 

Jul 7, 2009 at 4:09 PM

I'm playing around with the latest source 35151, and tried setting hymn of hope to 1 and got an exception in the debugger.

 

System.ArgumentException was unhandled
  Message=Object of type 'System.String' cannot be converted to type 'System.Single'.
  Source=mscorlib
  StackTrace:
       at System.RuntimeType.CheckValue(Object value, Binder binder, CultureInfo culture, BindingFlags invokeAttr)
       at System.Reflection.RtFieldInfo.InternalSetValue(Object obj, Object value, BindingFlags invokeAttr, Binder binder, CultureInfo culture, Boolean doVisibilityCheck, Boolean doCheckConsistency)
       at System.Reflection.RtFieldInfo.InternalSetValue(Object obj, Object value, BindingFlags invokeAttr, Binder binder, CultureInfo culture, Boolean doVisibilityCheck)
       at System.Reflection.RtFieldInfo.SetValue(Object obj, Object value, BindingFlags invokeAttr, Binder binder, CultureInfo culture)
       at System.Reflection.FieldInfo.SetValue(Object obj, Object value)
       at Rawr.RestoSham.CalculationOptionsPanelRestoSham.set_Item(String szFieldName, Object value) in c:\development\rawr\Rawr.RestoSham\CalculationOptionsPanelRestoSham.cs:line 144
       at Rawr.RestoSham.CalculationOptionsPanelRestoSham.cboDivineHymn_TextChanged(Object sender, EventArgs e) in c:\development\rawr\Rawr.RestoSham\CalculationOptionsPanelRestoSham.cs:line 256
       at System.Windows.Forms.Control.OnTextChanged(EventArgs e)
       at System.Windows.Forms.ComboBox.OnTextChanged(EventArgs e)
       at System.Windows.Forms.Control.set_Text(String value)
       at System.Windows.Forms.ComboBox.set_Text(String value)
       at System.Windows.Forms.ComboBox.UpdateText()
       at System.Windows.Forms.ComboBox.WmReflectCommand(Message& m)
       at System.Windows.Forms.ComboBox.WndProc(Message& m)
       at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
       at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
       at System.Windows.Forms.NativeWindow.DebuggableCallback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
       at System.Windows.Forms.UnsafeNativeMethods.SendMessage(HandleRef hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
       at System.Windows.Forms.Control.SendMessage(Int32 msg, IntPtr wparam, IntPtr lparam)
       at System.Windows.Forms.Control.ReflectMessageInternal(IntPtr hWnd, Message& m)
       at System.Windows.Forms.Control.WmCommand(Message& m)
       at System.Windows.Forms.Control.WndProc(Message& m)
       at System.Windows.Forms.ScrollableControl.WndProc(Message& m)
       at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
       at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
       at System.Windows.Forms.NativeWindow.DebuggableCallback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
       at System.Windows.Forms.UnsafeNativeMethods.CallWindowProc(IntPtr wndProc, IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
       at System.Windows.Forms.NativeWindow.DefWndProc(Message& m)
       at System.Windows.Forms.Control.DefWndProc(Message& m)
       at System.Windows.Forms.Control.WmCommand(Message& m)
       at System.Windows.Forms.Control.WndProc(Message& m)
       at System.Windows.Forms.ComboBox.WndProc(Message& m)
       at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
       at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
       at System.Windows.Forms.NativeWindow.DebuggableCallback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
       at System.Windows.Forms.UnsafeNativeMethods.DispatchMessageW(MSG& msg)
       at System.Windows.Forms.Application.ComponentManager.System.Windows.Forms.UnsafeNativeMethods.IMsoComponentManager.FPushMessageLoop(Int32 dwComponentID, Int32 reason, Int32 pvLoopData)
       at System.Windows.Forms.Application.ThreadContext.RunMessageLoopInner(Int32 reason, ApplicationContext context)
       at System.Windows.Forms.Application.ThreadContext.RunMessageLoop(Int32 reason, ApplicationContext context)
       at System.Windows.Forms.Application.Run(Form mainForm)
       at Rawr.Program.Main() in c:\development\rawr\Program.cs:line 28
  InnerException:

Developer
Jul 8, 2009 at 12:05 AM

I can confirm.  I get the same error (as far as I can tell) when changing the value of invervate or hymn of hope.  It isn't just to 1, it appears to be any change in the value.

Developer
Jul 8, 2009 at 7:15 PM

Should be a little cleaner.  I removed the innervate/divine Hymn/extra mana tide for two reasons, one to clean up the errors and two I started to think that maybe I was going a bit over-board on how accurate.  Of course I want it as accurate as possible, but I don't believe you should re-gem every single raid because you have an extra class A over class B.  This is the main reason burst was given it's own points, so haste would always have a value.  35201 should work much much cleaner now.

Developer
Jul 14, 2009 at 1:26 AM

Using build 35233, everything is looking pretty good.  However, the new slider for survival weight doesn't effect anything at this point in time.  Also still having problems selecting a totem from the ranged slot (its more than likely just my computer though).

Another funny thing worth mentioning is that looking at the stats panel, my mp5 is showing as 589.8893.  Is there a reason why I'm now seeing decimals there?

Developer
Jul 14, 2009 at 3:02 AM

Ah.  That's going to be pulled out, but that was more for internal testing. The mana gained from improved water shield and totem items are added into that, it was mainly for making sure it's working correctly.