This project is read-only.

Enhance weapons

Topics: Rawr.Enhance
Sep 23, 2009 at 5:32 AM

Currently, for Enhance shaman weapons, every viable weapon is listed, including primarily low dps, caster themed weapons. How can I make a filter so these caster weapons don't show up? I have to wade through dozens to find what I'm looking for.

Secondly, I'm curious as to why these weapons even show up. Are some really so much better than physical dmg, double the dps weapons, just because they have spellpower to raise my lava lash and shock dmg?

Last, and this has nothing to do with the title but, as often as I have to add new items to the item cache, I suppose its just gotten a little tedious. Could there be a direct Add Item command, without having to go through the Edit Item window?

Thanks for any and all help and insight.

Slayden, Silver Hand

Sep 23, 2009 at 9:42 AM

If the item has been put into the item cache then it shows up, if it has stats that are viable. It sounds like you have never touched the item filters. Have a look at the chart frame and the drop downs above it. There you will see Filters. Now change that to filter out what you are not interested in.

We cannot determine what you are interested in as that can be completely different from someone else, so YOU have to use the tools provided to select what YOU want. If a long list is a pain the easiest solution is to delete your ItemCache.XML file. Then run Rawr and import your character. Now select Load possible upgrades from Armoury (or Wowhead) and it will only populate the charts with items similar or better to what you have. That way a massive amount of lesser things are dropped and Rawr will run quicker.

Sep 28, 2009 at 5:43 AM

It seems like you skipped over the point of my post. I know about the filters, and I've used them for my hunter, rogue, priest, and druid of course. However, I see no filter that would allow me to do what I want for enhancement weapons. IE: Block any weapon with +spellpower

My question was "How can I make a filter so these caster weapons don't show up?".

If there is a filter that does this, could you name it for me, since I apparently can not find it? As it stands, the filters in the drop down menu you pointed out, that I regularly use for this toon and others, only includes filters for locations / expansions the items come from, which is not what I'm looking for. I've gone into Edit Item Filters to see if there are other filter options, but again, they are all for location of origin only. I would have to make my own filter, to block out the spellpower stat, but I do not know how. Which brings me back to my question.

How can I make a filter to do this, if it is even possible?

Sep 28, 2009 at 9:01 AM

No, Filters are not appropriate for this task. However, I'm not actually sure that this even *is* a correct task. If you've having to 'wade through' these weapons, then they actually *are* DPS upgrades for you.

I also wouldn't delete the itemcache; there's a whole lot of items there, and you'll miss tons of them if you try to manually (or via find upgrades) add them all. Additionally, you mention adding items being a hassle... That's confusing to me. What are you doing, where you find you frequently have reason to add items?

Sep 28, 2009 at 3:57 PM
Edited Sep 28, 2009 at 4:01 PM

Thanks Astrylian. I guess I'll just have to deal with it as it is.

I suppose for the way I play my shaman the spellpower EP values just seem too high. When I equip a spellpower weapon, my dps suffers, unless I change my rotation to accommodate, but that takes me out of my playstyle. I'll have to wait til another caster weapon drops within the quality of my current main and offhand weapons before I can do more testing. It just seems that a weapon with no enhancement stats other than Intellect, a 50 weapon dps decrease and an often faster weapon speed, should not be better or even on par with an Agi, AP, Crit, and Exp weapon, just because it has over 300 spellpower. Is there a way to alter the EP values to fit my own style or is that something I'm better off using a spreadsheet for? I'd much rather continue to use Rawr for my shaman as I do my other toons, and just ignore the items I personally don't find appealing, as spreadsheets confuse me to no end.

Anyway, I'll deal with that for now as I have been.

As far as how often do I need to add items, well, I suppose thats my own fault in that updating the itemcache takes quite awhile, and I'm an impatient person. The update also doesn't always find new items from holiday events ( I could probably wait a few days then update to resolve this ) or lower level items still on fresh 80's. So I end up adding them one by one. This would probably be more of a personal convenience, and doesn't reflect a flaw in Rawr. I'm a bit embarassed for even bringing it up.

I have one last question tho. Something I noticed on my druid last night. Between the Trinket 1 and Trinket 2 slots / charts, why do the bars shift (shorter or longer) and the trinkets change position relative to each other just by changing the charts from one to the other? I'll see a trinket at the 2nd BoS position for the first trinket slot, fall to 4th in a second trinket slot. I'm probably just missing something like a Unique item or some such that can't be used in both slots.

Sorry for any confusion and my ramblings.

Thanks again

Sep 28, 2009 at 4:50 PM

The Trinkets are relative to each other, Trinket 1 is factored into the changes for Trinket 2

if Trinket 1 is ItemA and it has a value of 84 crit and a 1000 AP proc and you wanna replace it with ItemB which is 84 Crit 500 STR proc then looking at Trinket 1 you will see DPS difference between THOSE 2 items, which could be fighting for BiS.

if Trinket 2 is ItemC and it has a value of 84 ArP and 700 Haste proc and you wanna replace it with ItemB (84 Crit 500 STR) then it's comparing ItemB and ItemC not ItemA.

Sep 28, 2009 at 6:34 PM

Also, there are no EP values. Rawr doesn't use stat weights. Items are valued by how much they contribute to your DPS, simple as that. I'm not familiar with how your rotation would have to change with a caster weapon, but if Rawr says a caster weapon beats your current weapon, that means that you could do more DPS with it. I'm not totally up on my Enh theorycraft myself, but I believe that only happens when going up to a higher ilvl. Most caster weapons have things like crit, haste, and hit ratings as well, which directly benefits enhance, since they're universal between casters and physical dps.

Sep 28, 2009 at 10:46 PM

Thanks Jothay and Astrylian for educating me. I much appreciate it. I'll just have to see how these other weapons effect my dps, when I can get ahold of one, and I may just have to adapt my playstyle to fit each weapon.

Thanks again for all the kind help. :)


Sep 29, 2009 at 5:31 PM

Simulation for Enhancement Shaman weapons seems broken to me at the moment.

It's currently telling me that MH-Masticator with OH-Frostbite Hatchet (245) is better than MH-Frostbite Hatchet (245) with OH-Vulmir, which is not true in practice.


I've also had Enhancement models that tell me to keep getting hit as my primary stat even when I have already hit the spell hit cap, with and without Misery/Faire Fire.

Sep 29, 2009 at 6:27 PM

You'll need to post your character file, demonstrating what you think is incorrect.

Sep 30, 2009 at 10:31 AM
Edited Sep 30, 2009 at 10:34 AM
mmattai wrote:

Simulation for Enhancement Shaman weapons seems broken to me at the moment.

It's currently telling me that MH-Masticator with OH-Frostbite Hatchet (245) is better than MH-Frostbite Hatchet (245) with OH-Vulmir, which is not true in practice.


I've also had Enhancement models that tell me to keep getting hit as my primary stat even when I have already hit the spell hit cap, with and without Misery/Faire Fire.

The spell hit cap for Enhancement shamans is NOT a solid cap. We also can gear hit towards the dual wield cap. This CAN increase our dps as it does a number of things namely... increased MW stacks (less white misses = more MW procs faster) more berserking procs off weapon enchants = more bonus AP uptime which of course gives more SP too, and of course more white dps.

So for Enhancement Shamans stopping at the spell hit cap is not always a good idea. Often having a lot of hit well beyond the spell hit cap is fantastic for our dps.

Please don't use EP values to work out what is good and what isn't. Run Rawr to see what items give best dps and use the Export to EnhSim to verify the Rawr calcs. We Enhancement Shaman have an excellent resource in EnhSim that gives us far more in-depth analysis than is desirable to have in Rawr. I've worked on Rawr to ensure that for the vast majority of users Rawr gives good solid results, I've also ensured that its quick and simple to export data from Rawr to EnhSim so that those that want to check my calcs in Rawr can do so using EnhSim.

This double checking also allows great sanity checking for myself as a developer making sure that the output from Rawr is accurate.


NB. I take the OP's point on board about spellpower items. I could include an option to ignore any weapon with spellpower if it really bothers you that much.

Oct 1, 2009 at 2:00 AM


I have been experiencing this situation as well.  Rawr is suggesting that I replace most of my gems with +hit gems, as well as my gloves enchant, thereby putting me well over the "cap".  I do understand that it isn't a cap per se and that +hit remains very beneficial, for instance over 342 for a Dranei with IFF or Misery.  However, I was skeptical and therefore I did what I was supposed to do -- simulate with EnhSim.  It turns out that, as I suspected, I'm getting better results with ap/crit (and haste but I won't touch that subject) than hit.  None of the simulations showed any benefit from adding hit beyond 342 instead of other stats. 

Also note that this does not always happen, which makes it even weirder.  Sometimes Rawr suggests what I would expect i.e. expertise to 26, hit to 340-350, and then ap/crit.  Sometimes it recommends hit to 400 or higher.  Simple swapping one item may produce dramatically different results regarding hit.  This is surprising; I know the effects of haste are difficult to guess (see other thread) but the effects of hit are fairly straightforward.  Either way, it doesn't agree with EnhSim which is the most important part.  Any thoughts?

Oct 1, 2009 at 12:13 PM

PLEASE PLEASE PLEASE supply me with a Rawr XML save file that has the hit to 340-350 and then simply swapping one item produces the dramatically different results.

I very strongly suspect there is a irritating little bug in the code, however whilst I can see some people getting the massive +hit recommendations and some getting perfectly normal recommendations I've never seen the trigger case where swapping one item switches between the two situations.

If I had an XML file and you said load that XML file and see that it all looks good, change item X and suddenly it goes hit crazy. Then I'd be able to trace what changes between the two states and thus work out what is going wrong and fix it.


Oct 1, 2009 at 6:59 PM

Levva, one thing I fixed recently that was giving me these sorts of results, was that I was flooring the stats received by SpecialEffects.GetAverageStats (notably Berserking).

This led to hit being where I expected it, unless I was a few rating points away from getting 1ap more from berserking (the same held true for haste, or crit with a mirror equipped, etc), and then have it bounce back.  I could view this at the "Relative Stat Value" tab (which isn't reliable, I know), but then practically when I slowly added hit rating I'd see my DPS increase 1.1, 1.1, 1.1, 3.4, 1.1, 1.1; an obvious bug.

We should not be flooring any stat coming from Special Effects due to the fact that it's an average/estimate; only floor stats when incorporating buffs with your base/unbuffed stats, as those are floored in the game.  Not sure if this is your bug or not, but thought I'd share it anyway.

Oct 1, 2009 at 10:38 PM

Hmm I was flooring the bonus Str or bonus Agi & AP from Paragon or highest stat buff in my special effects code. I've removed that. This might explain why it affects a small number of people if it is only affecting those with a "highest stat" or "paragon" proc trinket.

Now I suppose I need those that had the issue to tell me if they have one of those sorts of trinkets.


Oct 1, 2009 at 10:55 PM

Levva, I will try to reproduce this behaviour with my current character file.  It should not be too difficult as it has happened quite a few times in the past few days.  However, I don't see any way to attach files here, so should I email it? 

Also, I'm not using any "highest stat" or "paragon" proc trinket on this character, so unfortunately that isn't the issue here -- assuming there is even an issue. 

Oct 2, 2009 at 2:13 PM
Edited Oct 2, 2009 at 2:14 PM

Create a new Issue rather than a discussion you can attach files to an issue. Please make the subject clearly to do with Enhancement shaman eg: [Enh] Example of hit variability.

If you are trying to replicate and manage to get it down to just changing one gem that would be fantastic as that's only the effects of one or two stats to track, rather than the stats on an entire item.

Oct 2, 2009 at 8:34 PM
Edited Oct 2, 2009 at 8:44 PM

Hi Levva,

I haven't been able to reproduce the behaviour where Rawr recommends huge amounts of hit rating even though EnhSim disagrees.  More exactly, I did obtain 473 hit rating once but I forgot to save the file and the optimizer never generated the same configuration again. (Drawback of genetic algorithms.)

However, I was able to observe a situation which illustrates the problem to some extent, and which also conveniently matches your request.  After replacing a 40ap gem with a 20hit gem (going from 380 to 400 hit rating), Rawr displays a sharp increase (50 points!) in DPS.  EnhSim disagrees and calculates a minor decrease (5 points) in DPS, as I would expect since hit rating is still quite valuable after the "soft" cap.

I will create an issue later today to describe this problem.  Even though it isn't exactly the "huge hit rating" issue, it might help you pinpoint something related to hit rating.

*edit* I have created issue 14321.

Oct 7, 2009 at 8:00 PM

Great work on the plugin. Couple of comments - first I remember being stunned way way back when RAWR suggested I pick up Wraith Strike (+SP) over my Crimson Steel. It turned out to be a fantastic upgrade, and even though I kept getting questioned over it, the dps increase was undeniable. I never would have considered it if not for RAWR, and even though there are few viable +SP slow one-handers, I'm glad I gave it a shot... and I appreciate knowing where these types of weapons rank. Second re:hit, RAWR pushed me upwards of 460 before it eased off. I've wondered if having so much hit was truly more beneficial than other stats... but the dps has continued to increase, so what do I know :) Third, with 2.2.20 I've been unable to generate an XML for my enhsham, although the mage mod has no issues. Any ideas? I pulled fresh info from the armory, no luck saving it. Thanks!


Oct 7, 2009 at 8:07 PM

There's currently an annoying bug with saving characters who are leatherworkers. We're working on it, and hope to release a new version very soon.