1

Closed

FilterList for optimization

description

FilterList currently removes all items that are dominated. This is not desired behavior for rings. If the best ring dominates 2nd best ring and both are unique then 2nd best should not be filtered out.
 
Also when you're comparing for dominance an item can dominate more than one (you could have stats (2,4) on one, (4,2) on second which would both be added, item (5,5) then dominates both).
Closed May 5, 2008 at 10:45 PM by Kavan
Fixed.

comments

Astrylian wrote Apr 7, 2008 at 3:12 AM

Your first point is a bug, I'll fix that.

Second point, I don't understand. Is this not functioning properly? neither (2,4) or (4,2) should be included as options if (5,5) is available.

Kavan wrote Apr 7, 2008 at 4:55 AM

Neither should be included, but the way code is now it'll find the first one it dominates and remove that, it won't remove any others unless I'm missing something.

Astrylian wrote Apr 7, 2008 at 5:50 AM

Gotcha, found it. Thanks.

Kavan wrote Apr 7, 2008 at 11:43 AM

Current version crashes on optimize. You have removeItems = null in FilterList.