This project is read-only.

Holy Pally, Val'anyr, unable to add or see in list

Topics: Rawr.Healadin
Mar 17, 2010 at 8:43 PM
Edited Mar 17, 2010 at 9:16 PM

(Sorry wrong list, moved to Issue Tracker)

Since the latest version, Val'anyr, Hammer of Ancient Kings, has disappeared from the Main hand slot.
I loaded an older version 2.3.10 and it was in the item cache by default, in 2.3.12 it is not and I can't get it in.

Any get upgrades from armory or wow do not bring it back in.
Adding the its item-id 46017 shows it in the add item, but it still doesn't show up in the drop down.

Am I doing something wrong?


Mar 17, 2010 at 9:20 PM

Post this to the Issue Tracker please.

Mar 18, 2010 at 10:51 AM

The problem isn't that Val'Anyr isn't in the item cache. It clearly is in there, just load Rawr.Tree and you'll find the hammer there.

The problem is that the item relevancy checks are deeming the special effect as not relevant, and any item which has a special effect that isn't relevant gets filtered out, regardless of how good the rest of the item is.  This is a bit of a flawed approach towards item relevancy that was also present in Rawr.Retribution (but has been reworked entirely). Simple solution would be to add the proc effect to the list of relevant stats.  A better solution is likely to rework relevancy checks since healadin is currently removing some other items as well simply because the item has a proc that isn't being modelled (yet). I'm planning an update on the relevancy checks thread soon (tm) about my findings/observations about the relevancy thing.

Mar 18, 2010 at 5:02 PM

A bit of background... I reworked relevancy in 2.3.12 to more closely match Rawr.ProtPaladin's relevancy checking, which in turn was provided by Jothay (r37100).  It had to be tweaked a bit to remove items such as Abyssal Rune (which has a relevant stat, haste, but not a relevant proc, DamageSpellCast), and I've set it up so it shows things like stamina while not considering that particular stat relevant.  All in all, though, it's the same idea.

I'm not currently aware of any items missing from Rawr.Healadin, but I've also not fully checked for missing items, as is evident by the "missing" Val'anyr.  If there are any other items missing from Rawr.Healadin, please post an issue and I'll add them. :)

Mar 18, 2010 at 5:11 PM
OReubens wrote:

...the relevancy checks thread...

Oh hum, I missed that thread somehow.  Guess I have a bit of reading to do on lunch. :)

Mar 22, 2010 at 10:23 AM

Working on the post text atm, but still need to clean up the code in Rawr.ret as that code still has both the old and new relevancy checking (defaulted to new) and it's currently looking a bit messy.