This project is read-only.

Smart Item Lists

Topics: Retired
May 11, 2008 at 12:15 PM
Currently the list in the popup form showing your gear alternatives for a slot is getting quite long thanks to the optimiser generating loads of different gemings. This unfortunately makes the list less readeable than desired.

I believe it would be nice to add a "smart" list mode to it to cut down that list:
- For all items (based on Item._name), it would calculate the best rating available
- The list would be reduced to all item variants matching the best rating for that item plus
- all variants in geming for the currently equipped item.

That should reduce the length of the lists considereably. It might also be worthwhile if
- items with a rating of zero and/or
- less than 50% rating of the currently equipped item
would be filtered out as well (unless the item is the currently equipped one, then it should stay), especially with druid gear lists containing gear for loads of different purposes, where 60%+ of it is not relevant at all.

(And I believe it can be localised in FormItemSelection.RebuildItemList)
May 11, 2008 at 2:45 PM
I put an inital attempt at a smart list in the patches section. It currently has the smart handling as a flag, so it could be easily extended to incoorperate smart list as a display option.
May 11, 2008 at 6:05 PM
Declined, as we specifically *don't* want that sort of filtering. The desire for it will be drastically reduced in b14 already.
May 12, 2008 at 10:14 AM
Edited May 12, 2008 at 10:17 AM
Would you care to explain how you will achieve the same result in b14 then? This kind of filtering makes Rawr a lot more useable, and I regard a way to deal with gemming variants essential from making the items list unsueable because of 10+ variants for each item.

Also would you like to explain what are your plans for ensuring that Rawr will not use more than 10000 USER objects (the hard limit in Vista), when it currently can use 8K+ already?
May 12, 2008 at 4:17 PM
If those variants are not useful to you, delete them (Delete Duplicates is a quick way to do that). If you know of a way to create a handle leak in b14, let me know.
May 12, 2008 at 5:38 PM
The issue is ofc that variants are useful, even if you dont want to see all of them, because it means you get the value from the best gemming automatically. This is especially relevant for feral druids, as they tend to keep dps and tanking variants of items around. And from my experience with this smart filtering it is pretty good at hiding only items you are not interested in. You might want to try it before rejecting it :)

Also delete duplicates is a lot of hand work to clean up your items, while a global delete duplicates might be much too aggressive. Since the root cause for the number of duplicates floating around is the optimiser, it might be best to have variants store whether they were created by the optimiser, and allow you to remove optimiser created options only. The optimiser creation flag should be cleared on items that are equipped on a saved character, and then a global delete duplicates could remove all optimiser generated gemmings (unless it is the only gemming currently available for that item).

As for the handle issue, I believe it is directly related to the way ItemSelectorItem is implemented. It has 12 sub controls, meaning that for a display list of 400 items for a slot, 5200 controls are created. That is the root of the problem, and to fix it, either the control needs to draw stuff without making use of subcontrols, or it even better the list changed to use an owner drawn listbox.
May 12, 2008 at 6:16 PM
Users don't want to see just the 'best' gemming. That's why this was rejected. The number of crazy gemmings created by the Optimizer should be far fewer in b14, so that removes alot of the desire for this.

I may implement ItemSelectorItem as custom drawn for b14.1.
May 12, 2008 at 6:33 PM
I know, that is why for the currently equipped item I made it so that it shows all known gemmings as well.
May 12, 2008 at 7:46 PM
I know, that is why for the currently equipped item I made it so that it shows all known gemmings as well.