Hey Solieu ;o
Current live build 3.0.9 (9551):
The damage fomula for ShoR is (using your rawr variable names) cs.ShoRDamage = (stats.BlockValue +
400f) * damageMulti * SotT * holyMulti;
300 is the value used for rank 1, the corect value for rank 2 is 400. Sadly Cathela isn't updating her post on EJ anymore, if you happened to grab the values from there, be aware she only listed Rank 1 of that ability.
PTR build 0.1.0 (9626):
The damage multiplier of SotT gets removed from the talent and folded into the base abilities. All in all the damage of the ability won't change.
cs.ShoRDamage = (1.3f * stats.BlockValue + 520f) * damageMulti * holyMulti;
About ShoR BV from judgement:
What I did with the Libram in my previous Rawr versions was to manually edit the Libram and add 352 * 5 / 9 = 195 BV in the item properties. Most on use attack power trinkets average the bonus over their cooldown value and I personally was fine with that
estimate for the block value as flat bonus.
I don't think it's smart to change the formula for ShoR damage to include the judgement BV the way you did though, since it isn't really correct to have
all ShoR hits be affected by it on average.
My suggestion is to add two new variables for now:
cs.ShoRJBVDamage = (stats.BlockValue + 400f + JudgementBlockValue) * damageMulti * SotT * holyMulti;
cs.ShoRJBVThreat = cs.ShoRDamage * holyThreatMod * (1f - cs.ToMiss + cs.ToCrit);
and modify the section where you calculate your threat rotation (cs.Rot1TPS and cs.Rot1DPS), only here can you really know how many ShoR hits with increased BV from Judgement you have to take into account. It will also help once we implement an option for
Side note about rotations: 9696 was developed as maximum average threat rotation, even though it drops two out of three possible JoV->ShoR moves. I think we're best off ignoring custom rotations for now an only implement the judgement glyph and keep an
eye out for 3.1 glyphs.
About Mitigation from judgement block value:
A paladin tank will always use HS and Judgement as a first priority in any mitigation calculation, first of all to increase the block chance and to debuff the attacker with Judgements of the Just (thunderclap).
Currently damage when hit is calculated by cs.DamageWhenHit = cs.Block / beHit * cs.DamagePerBlock + cs.Hit / beHit * cs.DamagePerHit + cs.Crit / beHit * cs.DamagePerHit * 2;
so it all boils down to cs.DamagePerBlock = cs.DamagePerHit - stats.BlockValue; it's here that the Libram needs to be calculated for.
To make it depend on talents spent in Improved Judgement and druation of the buff itself:, change it to:
cs.DamagePerBlock = cs.DamagePerHit - (stats.BlockValue + 5f / (10f - talents.ImprovedJudgments) * JudgementBlockValue);
What do you think ?